Put wer tag entity type in SBS output #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishchalb
commented
May 31, 2022
src/wer.cpp
Outdated
| string tk_classLabel = tk_pair->classLabel; | ||
| string ref_tk = tk_pair->ref; | ||
| string hyp_tk = tk_pair->hyp; | ||
| /* while (visitor.NextTriple(tk_pair)) { */ |
There was a problem hiding this comment.
TODO: delete unused code
There was a problem hiding this comment.
yea doesn't this mean no more topAlignment needed?
There was a problem hiding this comment.
It still gets used below
There was a problem hiding this comment.
for the ngrams? goodness that's yucky. I guess at least get rid of the tk_pair and visitor initialization then
qmac
approved these changes
Jun 6, 2022
dchen579
reviewed
Jun 21, 2022
|
|
||
| NlpFstLoader::NlpFstLoader(std::vector<RawNlpRecord> &records, Json::Value normalization, bool processLabels) | ||
| NlpFstLoader::NlpFstLoader(std::vector<RawNlpRecord> &records, Json::Value normalization, | ||
| Json::Value wer_sidecar, bool processLabels) |
There was a problem hiding this comment.
Nit: put nWerSidecar(wer_sidecar) in initializer list instead of line 27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WER tag sidecar file carries accompanying info for tokens in a NLP file. One such type of info is an "entity_type" like NER tags. This type of info is useful to see in the output SBS file.