Migrate tests to modern JUnit Jupiter #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project currently uses the outdated JUnit 4.13.2. In order to make it easier to write tests and easier for future contributors to easily start working with the project, this path migrates the test suite to the modern JUnit Jupiter. Changes: - The junit:junit:4.13.2 dependency was replaced with org.junit.jupiter:junit-jupiter:5.8.1. - The org.junit.jupiter.api.Test annotation was used as a drop-in replacement for org.junit.Test - The static imports from org.junit.jupiter.api.Assertions were used as drop-in replacements for the static imports from org.junit.Assert. - LineEndingEdgeCasesTest was rewritten to use JUnit Jupiter's org.junit.jupiter.api.io.TempDir annotation instead of JUnit 4's org.junit.rules.TemporaryFolder.
mureinik
added a commit
to mureinik/impsort-maven-plugin
that referenced
this pull request
Oct 2, 2021
This patch follows up on the review given for revelc#51 and uses maven-surefire-plugin's configuration to set the tempdir to target and restore the behavior change introduced in that PR. Note: This fix will only effect running the test via maven. If the test is manually run (e.g., from an IDE), java.io.tmpdir should be overridden manually too.
mureinik
added a commit
to mureinik/impsort-maven-plugin
that referenced
this pull request
Oct 2, 2021
This patch follows up on the review given for revelc#51 and uses maven-surefire-plugin's configuration to set the tempdir to target and restore the behavior change introduced in that PR. Note: This fix will only effect running the test via maven. If the test is manually run (e.g., from an IDE), java.io.tmpdir should be overridden manually too.
ctubbsii
added a commit
that referenced
this pull request
Oct 2, 2021
This patch follows up on the review given for #51 and uses maven-surefire-plugin's configuration to set the tempdir to target and restore the behavior change introduced in that PR. Note: This fix will only effect running the test via maven. If the test is manually run (e.g., from an IDE), java.io.tmpdir should be overridden manually too. Move surefire version to managed property by overriding property in parent POM Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project currently uses the outdated JUnit 4.13.2. In order to make it easier to write tests and easier for future contributors to easily start working with the project, this path migrates the test suite to the modern JUnit Jupiter.
Changes:
junit:junit:4.13.2dependency was replaced withorg.junit.jupiter:junit-jupiter:5.8.1.org.junit.jupiter.api.Testannotation was used as a drop-in replacement fororg.junit.Test.org.junit.jupiter.api.Assertionswere used as drop-in replacements for the static imports fromorg.junit.Assert.LineEndingEdgeCasesTestwas rewritten to use JUnit Jupiter'sorg.junit.jupiter.api.io.TempDirannotation instead of JUnit 4'sorg.junit.rules.TemporaryFolder.