This repository was archived by the owner on Jun 6, 2020. It is now read-only.
Reduce deps #59
Draft
Reduce deps #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Et7f3
force-pushed
the
Et7f3-reduce-deps
branch
from
227848f to
ddefb71
Compare
|
I have force pushed because I have forgotten to remove dune@<2.1 to test ocaml@4.6 |
lessp
reviewed
Apr 14, 2020
There was a problem hiding this comment.
- Works when linked locally to Revery
- Example runs (
esy @example run)
However, trying to build with esy @js fails with:
info building @opam/js_of_ocaml-lwt@opam:3.5.2@6ea3e3c2: done
ocamlc bin_js/test_sdl2.bc (exit 2)
(cd /Users/ter/dev/diverse/reason/reason-sdl2/_esy/js/store/b/reason_sdl2-80afa601/default && /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/bin/ocamlc.opt -w -40 -g -o bin_js/test_sdl2.bc /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__js__of__ocaml-opam__c__3.5.2-b18b0af9/lib/js_of_ocaml/js_of_ocaml.cma /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__result-opam__c__1.5-e2b3383e/lib/result/result.cma /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__lwt-opam__c__5.2.0-11443f49/lib/lwt/lwt.cma /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/lib/ocaml/unix.cma /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.9.0-27f2b357/lib/ocaml/bigarray.cma src/sdl2.cma -I src /Users/ter/.esy/3_____________________________________________________________________/i/reason_native__s__console-0.1.0-c22d4f3f/lib/console/lib/Console.cma examples/sdl2example.cma bin_js/.test_sdl2.eobjs/byte/test_sdl2.cmo)
File "_none_", line 1:
Error: Error on dynamically loaded library: ./src/dllsdl2_stubs.so: dlopen(./src/dllsdl2_stubs.so, 10): Symbol not found: _NSApp
Referenced from: ./src/dllsdl2_stubs.so
Expected in: flat namespace
in ./src/dllsdl2_stubs.so
error: command failed: 'dune' 'build' '-p' 'sdl2,sdl2-js' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
esy: exiting due to errors above
EDIT:
On master esy @js gives the following:
❯ esy @js
info esy 0.7.0-66428e (using js.json)
File "bin_js/dune", line 4, characters 21-28:
4 | (preprocess (pps lwt_ppx))
^^^^^^^
Error: Library "lwt_ppx" not found.
Hint: try: dune external-lib-deps --missing --root . @@default
error: command failed: 'dune' 'build' '--root' '.' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
esy: exiting due to errors above
|
Should we do something about the JS-build? @Et7f3 |
|
I really don't know what happen here. I will try to investigate after. |
|
@lessp on master can you add: |
|
We had similar issuer with sdl https://discordapp.com/channels/526111832478449695/532721901886504981/676493496575590417 |
Can confirm it builds on master when adding this to |
Et7f3
force-pushed
the
Et7f3-reduce-deps
branch
from
d8c339c to
380164a
Compare
|
Ok I am rebasing because a unused deps was already removed d679957 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove dependencies on refmterr (used only at build time) and esy-cmake 👀 I wonder why it was their.
Rationale: I have low disk space on my linux partition so try to reduce revery size globally. Another reason: less dependencies mean more easier to update. Now to publish to opam we need to publish our patched esy-sdl2 and this package is ready.