This repository was archived by the owner on Jun 6, 2020. It is now read-only.
API: Add Path.addCircle, addRoundRect, close #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Et7f3
reviewed
Apr 8, 2020
lessp
commented
Apr 8, 2020
Removed it and added it to |
Anything else holding this back @Et7f3? |
Et7f3
reviewed
Apr 15, 2020
File "src/Skia.re", line 462, characters 2-53: Error (warning 34): unused type pathDirection. File "src/Skia.re", line 463, characters 6-19: Error (warning 32): unused value pathDirection.
Et7f3
reviewed
Apr 16, 2020
|
I see in the man that their is a default value to ClockWise. Maybe when you re export you could define a function with a default arg. :) Otherwise seem good to merge. |
Co-Authored-By: Et7f3 <cadeaudeelie@gmail.com>
Et7f3
reviewed
Apr 16, 2020
Et7f3
approved these changes
Apr 16, 2020
|
Perfect, thanks @Et7f3! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bindings for
Path.addCircle,addRoundRect,close. This is new ground for me, so please make sure I've not missed something! 😄https://api.skia.org/classSkPath.html#a2daa24dc5e277a487c80e2de4469bfb3