Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Regression: PR #445 caused a blank screen on startup #456

Merged
merged 3 commits into from
Apr 13, 2019

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Apr 13, 2019

Issue: For apps that don't have an animation or initial event to trigger a dirty window, the screen will be blank until something triggers a dirty state.

Defect: Previously, before #445 , we had a needsRender value on the app instance that was set to true on startup, and anytime an action was dispatched against our ad-hoc state management. When that was removed, if nothing triggered a dirty event, a render would never be triggered.

Fix: Always render the first frame. Bring back a limited version of needsRender in the form of isFirstRender

@bryphe
Copy link
Member Author

bryphe commented Apr 13, 2019

@msvbg , does this fix the issue you hit with #445 ?

@msvbg
Copy link
Contributor

msvbg commented Apr 13, 2019

Yes, this appears to fix the issue :)

@bryphe
Copy link
Member Author

bryphe commented Apr 13, 2019

Thanks for the confirmation @msvbg ! 👍

@bryphe bryphe merged commit 3de4d76 into master Apr 13, 2019
@bryphe bryphe deleted the bugfix/regression-445-blank-window branch April 13, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants