Fix an encoding error where revision svn is expected as bytes, not str. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error that occurs when I attempt to do
rbt post
from a git+svn workspace, from my Win10 PC running Git Bash.The fix as authored appears to be the correct behavior. The code clearly expects
rev
to be a bytes value, not a string. The fact thatexecute()
is apparently returning bytes results for anyone whenresults_unicode=True
(I have reports it works for most people) seems like an error inexecute()
that should probably be investigated separately.OS information:
The backtrace of the crash which this change fixes: