Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensible default value for exclude param #70

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
file: testdata/testfile
version_name: REVIEWDOG_VERSION
repo: reviewdog/reviewdog

- name: Check diff
run: git diff

Expand All @@ -30,7 +29,6 @@ jobs:
file: testdata/testfile
version_name: REDPEN_VERSION
repo: redpen-cc/redpen

- name: Check diff
run: git diff

Expand All @@ -44,7 +42,6 @@ jobs:
file: testdata/testfile
version_name: TMUX_VERSION
repo: tmux/tmux

- name: Check diff
run: git diff

Expand All @@ -58,7 +55,6 @@ jobs:
file: testdata/testfile
version_name: POETRY_VERSION
repo: python-poetry/poetry

- name: Check diff
run: git diff

Expand All @@ -73,7 +69,6 @@ jobs:
version_name: THEMIS_VERSION
repo: thinca/vim-themis
tag: true

- name: Check diff
run: git diff

Expand All @@ -88,7 +83,6 @@ jobs:
version_name: TERRAFORM_VERSION
repo: hashicorp/terraform
include: '^\d+\.\d+\.\d+$'

- name: Check diff
run: git diff

Expand All @@ -103,6 +97,32 @@ jobs:
version_name: TERRAFORM_VERSION
repo: hashicorp/terraform
exclude: '-(alpha|beta|rc)'
- name: Check diff
run: git diff

exclude-default:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./
id: depup
with:
file: testdata/testfile
version_name: TERRAFORM_VERSION
repo: hashicorp/terraform
- name: Check diff
run: git diff

exclude-remove:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./
id: depup
with:
file: testdata/testfile
version_name: TERRAFORM_VERSION
repo: hashicorp/terraform
exclude: '' # empty
- name: Check diff
run: git diff
1 change: 1 addition & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ inputs:
required: false
exclude:
description: 'Regular expression not to use matched versions.'
default: '\b(rc|alpha|beta)(\b|\d+)'
required: false
outputs:
current:
Expand Down
1 change: 1 addition & 0 deletions with-pr/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ inputs:
required: false
exclude:
description: 'Regular expression not to use matched versions.'
default: '\b(rc|alpha|beta)(\b|\d+)'
required: false
tag_prefix:
description: 'Tag prefix used for building link in PR description'
Expand Down