Fix release action #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the javascript-based action with a composite gh action. This was done since the javascript had several downsides: - Debugging unnecessarily complicated since multiple bash commands were executed inside subshells. - Maintainers needed to remember to build the javascript package before deploying. This commit contains the following breaking changes: - It does no longer support windows. This, however, can be easily added might somebody need it. - This version depricates the (redundant)`update_pip, install_deps, dev_install, req_file_path, flake8_version, exclude, ignore, max_line_length` action input arguments.
Github was not really happy with the gh-action agent creating this many annotations. I therfore now only test the action with the python 3.8. We might have to update this in the future.
This commit makes sure the reviewdog binary is removed after the main action has run. It further contains some small bug fixes and documentation changes.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
flake8
testdata/subfolder/queen_problem.py|40 col 11| at least two spaces before inline comment
testdata/subfolder/queen_problem.py|40 col 57| no newline at end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release GitHub action appears to be broken as the branch name that is used is wrong. This pull request fixes this.