Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use temporary directory for download trivy #31

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Use temporary directory for download trivy #31

merged 1 commit into from
Mar 20, 2024

Conversation

nayuta
Copy link
Contributor

@nayuta nayuta commented Mar 11, 2024 •
edited
Loading

Fix: #32

Changes:

  • create and use a temporary directory (with mktemp -d) for download trivy archive

Reasons:

  • In the current version, the script downloads the trivy archive to the working directory. However, the scripts assume the working directory is for checking, and sometimes, the download fails.

@nayuta nayuta self-assigned this Mar 11, 2024
shogo82148
shogo82148 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shogo82148 shogo82148 merged commit 197124f into reviewdog:main Mar 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees

@nayuta nayuta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downloading trivy would be failed if the working directory is not writable.
2 participants
@nayuta @shogo82148