Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trivy command and target #5

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Support trivy command and target #5

merged 3 commits into from
Dec 8, 2023

Conversation

nayuta
Copy link
Contributor

@nayuta nayuta commented Dec 6, 2023 •
edited
Loading

Trivy supports multiple scan types but tfsec only supports terraform scan. So I added two parameters.

  • trivy_command
    • Tirvy command (for scanning terraform, we need to use config)
  • trivy_target
    • Target to scan (with tfsec, it set to .)

Related conversation: reviewdog/action-tfsec#112 (comment)

@nayuta nayuta mentioned this pull request Dec 6, 2023
Open
@nayuta nayuta marked this pull request as ready for review December 6, 2023 13:33
shogo82148
shogo82148 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit 0465151 into reviewdog:main Dec 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayuta @shogo82148