fix: don't permit account deletion if user owns servers #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maxgorovenko <gooomax@gmail.com>
|
@erkinalp, could you provide more information to this pr, except down emoji? |
|
my alternative is to simply leave the guild behind ownerless and delete the user account anyway |
|
Oh, my bad. Checked if current user is server owner, Its totally wrong. But checking if kicking member is server owner is already exists here. Looks like I don't have to do anything for now.. |
|
The PR is itself invalid. The issue is about preventing manual user account deletion if user owns some guilds. This PR prevents server owner from kicking other members. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
Issue #315