Declare index typings #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for skypack compatibility with Deno
|
I updated the PR to accommodate the latest changes. |
insertish
approved these changes
Apr 24, 2022
|
https://cdn.skypack.dev/-/revolt.js@v6.0.0-rc.15-i2YPAc8ICFrachs4bfh2/dist=es2019,mode=types/dist/index.d.ts Thanks for approving this workaround in the meantime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.skypack.dev/package-authors/package-checks#types
Getting typings called by skypack allows Deno users wishing to use revolt.js to see the typings.
This doesn't close my issue but it does work around the issue. We should still see if we could make a Deno compatible build by default rather than rely on this third party app but it works.
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package
It's also what the TypeScript specifications recommend