Skip to content
This repository has been archived by the owner on May 10, 2018. It is now read-only.

made sure that we stay on active "slide" when elements are added to the head of the watched collection #191

Closed
wants to merge 1 commit into from

Conversation

kaililleby
Copy link

While adding elements to the tail of the watched collection works fine, adding to the head has the undesired effect of also changing the active slide (since the element pointed to by the index changes when we add to the head of the collection). This commit compensates for this - BUT - not knowing all the details of the carousel implmentation - there might be corner cases im not aware of..
Any thoughts?

@revolunet
Copy link
Owner

Thanks, great fix, looks good to me :)

@revolunet
Copy link
Owner

in fact this is based on a quite old version so i merged it manually, thanks

@revolunet
Copy link
Owner

thanks, i implemented this on the new version : 6ff425d

this is a bit more complicated because the $watchCollection simply don't work correctly angular/angular.js#2621 i didnt find a better way

@revolunet revolunet closed this Nov 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants