Cherry pick "Add support for alternate app icons in UIKit via actool in Xcode 14+..." #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(first introduced in 13). PiperOrigin-RevId: 578548155
acecilia
reviewed
Jul 26, 2024
| @@ -2518,6 +2519,7 @@ ios_application = rule_factory.create_apple_rule( | |||
| rule_attrs.app_icon_attrs( | |||
| icon_extension = ".appiconset", | |||
| icon_parent_extension = ".xcassets", | |||
| supports_alternate_icons = True, | |||
There was a problem hiding this comment.
[question] Is this safe and backward compatible?
| @@ -159,7 +160,6 @@ def _asset_catalogs( | |||
| assets_plist = None | |||
| infoplists = [] | |||
| if not parent_dir: | |||
| # TODO(kaipi): Merge this into the top level Info.plist. | |||
There was a problem hiding this comment.
[question] Why remove this TODO?
There was a problem hiding this comment.
I don't know.
This is a clean cherry-pick of the original commit 6fc1952, with only formatting and docs being changed from my side (through repo's automation).
acecilia
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick: 6fc1952
Resolve: bazelbuild#1261
Follow up: bazelbuild#2291
Mirror: bazelbuild#2505