Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting the screen height to auto. #136

Closed
wants to merge 1 commit into from
Closed

Resetting the screen height to auto. #136

wants to merge 1 commit into from

Conversation

t-arpin
Copy link

@t-arpin t-arpin commented Apr 14, 2023

Resetting the screen height to auto because it caused some funny glitches. #22 & #122

This should hopefully fix it :)

Resetting the screen to auto because it caused some funny glitches.

This should hopefully fix it :)
@vercel
Copy link

vercel bot commented Apr 14, 2023

@Tristan3D3 is attempting to deploy a commit to the reworkd Team on Vercel.

A member of the Team first needs to authorize it.

@t-arpin t-arpin changed the title Resetting the screen to auto. Resetting the screen height to auto. Apr 14, 2023
@awtkns
Copy link
Member

awtkns commented Apr 14, 2023

@Tristan3D3 would you be able to share before and after images?

@@ -75,3 +75,8 @@ div::-webkit-scrollbar-thumb {
div::-webkit-scrollbar-button {
display: none;
}

/* Height of page was limited so changing it back to auto */
.h-screen {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we want do be doing these changes only in tailwind.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just changes the "h-screen" property in tailwind to default to auto if not set
I think it's kinda still tailwind

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we want do be doing these changes only in tailwind.

PR #159 resolves this :)

@t-arpin
Copy link
Author

t-arpin commented Apr 14, 2023

@Tristan3D3 would you be able to share before and after images?

Before :
image

After :
image

@Charlz4500
Copy link

Apr

@vercel
Copy link

vercel bot commented Apr 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2023 0:44am

@awtkns
Copy link
Member

awtkns commented Apr 15, 2023

@Tristan3D3 doesnt seem to be working for me :(

Screen Shot 2023-04-15 at 4 55 34 PM

@rahul-ghimire-au6
Copy link
Contributor

hey @awtkns, to re-create this issue please turn on chrome's dev mode, by "right-clicking" then clicking "inspect"
please select responsive and add this screen resolutions 1336 * 600
have added support fix for this issue in this pr and also screen shots (#158)

@t-arpin
Copy link
Author

t-arpin commented Apr 15, 2023

@Tristan3D3 doesnt seem to be working for me :(

Screen Shot 2023-04-15 at 4 55 34 PM

Okay I see
Currently working on a fix

@t-arpin
Copy link
Author

t-arpin commented Apr 15, 2023

Okay I see Currently working on a fix

Issue fixed in PR #159 :)

@t-arpin t-arpin closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants