Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing the collapsible drawer feature #327

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Addressing the collapsible drawer feature #327

merged 4 commits into from
Apr 24, 2023

Conversation

rp-bot
Copy link
Contributor

@rp-bot rp-bot commented Apr 23, 2023

Fixed issue #261

Changes made:

  1. Removed one of the <FaBars/> icon and consolidated into one.
    • line 60-66
  2. Added an animation for the <FaBars/> icon to make a seamless transition.
    • line 79
  3. Removed line 73 and consolidated it into line 71
  4. Removed duplicate styles in line 161 and line 178

Gives rise to adjunctive issues:

  1. Default Drawer state is always closed even on larger screens.
    Potential solution:
    • Add a condition to evaluate screen-type.
    • Save state in local storage.
const [myState, setMyState] = useLocalStorageState('myStateKey', 'initialValue');

@vercel
Copy link

vercel bot commented Apr 23, 2023

@rp-bot is attempting to deploy a commit to the reworkd Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 1:13am

@asim-shrestha
Copy link
Contributor

Hey good stuff, I see some of the same issues as #307 here.

With desktop, we want this drawer open by default and it should actually take up screen space when open. This is in contrast to mobile which is closed by default and acts as just an overlay on TOP of the page.

Note for the next pull request (Lets just fix the above and get this in) when the drawer is collapsed on desktop, we should be releasing screen space so that we can view more of the text.

@asim-shrestha
Copy link
Contributor

BTW, since you're already pretty active here, would love to add you to our dev channel on discord. Feel free to DM me on discord if you're interested

@asim-shrestha
Copy link
Contributor

Hey made the updates, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants