feat(#33): implement model input #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jshen123 is attempting to deploy a commit to the reworkd Team on Vercel. A member of the Team first needs to authorize it. |
Jshen123
changed the title
|
CC: @asim-shrestha |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
awtkns
reviewed
Apr 13, 2023
| @@ -56,11 +60,23 @@ export default function SettingsDialog({ | |||
| link. | |||
| </a> | |||
| </p> | |||
| <Input | |||
There was a problem hiding this comment.
Ideally I think this should be a drop down. But we can make that improvement later.
There was a problem hiding this comment.
Told him drop down could wait for a diff push
src/components/SettingsDialog.tsx
Outdated
| <span className="ml-2">Model:</span> | ||
| </> | ||
| } | ||
| placeholder={""} |
There was a problem hiding this comment.
Might be good to have a place holder here. A default value would be even better 😊
There was a problem hiding this comment.
lets do a placeholder of gpt-3.5-turbo
asim-shrestha
approved these changes
Apr 14, 2023
asim-shrestha
pushed a commit
that referenced
this pull request
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
allow user to input custom model name