Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow truncation to be disabled #122

Merged
merged 1 commit into from
Jun 8, 2019

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Jun 3, 2019

  • org-cliplink-string.el (org-cliplink-elide-string): Return the string without truncation if max-length is nil.
  • org-cliplink.el (org-cliplink-max-length): Change type to a choice of integer or nil.
  • test/org-cliplink-string-test.el (org-cliplink-elide-string-test): Add test case with no max length.

Copy link
Owner

@rexim rexim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please extend org-cliplink-elide-string-test to take this new behavior into account?

(ert-deftest org-cliplink-elide-string-test ()

* org-cliplink-string.el (org-cliplink-elide-string): Return the string
without truncation if max-length is nil.
* org-cliplink.el (org-cliplink-max-length): Change type to a choice of
integer or nil.
* test/org-cliplink-string-test.el (org-cliplink-elide-string-test): Add
test case with no max length.
@Miciah Miciah force-pushed the allow-truncation-to-be-disabled branch from 22aaf09 to 40ae483 Compare June 8, 2019 21:14
@Miciah
Copy link
Contributor Author

Miciah commented Jun 8, 2019

Latest push adds a test case to org-cliplink-elide-string-test with max length set to nil. Does it look all right?

@rexim
Copy link
Owner

rexim commented Jun 8, 2019

@Miciah yep! Looks good. Thanks for the contribution!

@rexim rexim merged commit 82402ca into rexim:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants