feat: update i18n module and adapt config folder and trad files #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was
linked to
issues
Dec 12, 2024
manuelodelain
requested changes
Dec 18, 2024
| }, | ||
| { | ||
| code: locale, | ||
| file: `nuxt.${locale}.default.json`, |
There was a problem hiding this comment.
I don't think it's a good idea to split translations into multiple files. The default file won't be available into xilofone
Comment on lines
+3
to
+5
| export function isAvailableI18nLocale(locale: string): locale is typeof I18N_LOCALES[number] { | ||
| return (I18N_LOCALES as unknown as string[]).includes(locale) | ||
| } |
There was a problem hiding this comment.
We should only rely on Nuxt I18n at runtime, not on constants. All the available translations are available on $i18n.locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.