[88] Map: style toggles

[Nutto55]

✅ DoD

• Resolves Map: style toggle #88
• Documentation na
• CHANGELOG updated

📝 Summary

• Add 2 buttons to provide abilities to toggle map style between default(street) and satellite with show/hide map labels option each

💉 Testing

• Select the data between April 1, 2021 - April 7, 2021.
• Try toggle the pen and artist icons on the top right of map component and see the change

🛑 Problems

• The current version have looping to setting label display on map style. If there is a performance issue, then we can ask to create a custom map to handle all the case.
• I think the UI need some finetune which @naluinui can suggest a better idea.
• Green color is look unclear when it is on satellite map

💡 More ideas

• We should check if the user have performance issue before we asking to create a custom map to handle all the case.

📸 Screenshots

🙋 Reviewer Guidance

• Please check my looping logic and UI carefully.

[charles-allen]

Changes are here (to support discussion)

[charles-allen]

Replies to your PR...

The current version have looping to setting label display on map style. If there is a performance issue, then we can ask to create a custom map to handle all the case.
...
We should check if the user have performance issue before we asking to create a custom map to handle all the case.

Do you mean, there are 2 approaches to this?

• 4x maps
• 2x maps + loop to toggle layer visibility

I see no performance issues with your layer code, and I think you picked the more intuitive approach! Since I think the performance depends on the map, not the datasets, I also expect this to be fine for other users & scenarios.

💚 TL;DR: I think you did a good job with the labels!

I think the UI need some finetune...
Green color is look unclear when it is on satellite map

IMO, this isn't a priority for your PBI/PR!!

[naluinui]

Chaz's comments already covered everything. One point I wanted to add is only the boolean variable name as mentioned in the comments below.

How about this for style:

ref:

Again you can create a new PBI to work on the style if needed

[naluinui]

Here is how they handle it in Arbimon

Screen.Recording.2564-10-02.at.14.32.43.mov

[naluinui]

This is the final design I proposed in one of Slack thread

Toggle group button

• Satellite (selected by default)
• Streets

Check box button

• ✔️ labels (checked by default)

[Nutto55]

This is the updated UI change:

[naluinui]

only tiny UI that I've mentioned in Slack thread about moving label button up to the baseline

Apart from that, it's all nice work! Thanks Nutto!