Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramsey Discounting and Equity Weighting Options #49

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Jul 12, 2021

TODO items

  • add Ramsey discounting and equity weighting options to deterministic scc runs
  • add Ramsey discounting and equity weighting options to mcs runs
  • update documentation in notebooks and README, and add tests
  • update the examples in a second PR when this is all merged

@lrennels lrennels changed the title Add Ramsey discounting options for determinstic runs Ramsey Discounting and Equity Weighting Options Aug 6, 2021
@lrennels lrennels marked this pull request as ready for review August 7, 2021 01:48
@lrennels
Copy link
Collaborator Author

lrennels commented Aug 7, 2021

@bryanparthum I am revisiting this repository to add Ramsey discounting and equity weighting options for some work I am doing, which we may or may not merge depending on how confusing it would be for current users (we can discuss that when the time comes). In this work I was adopting the drop discontinuities stuff, and noticed that their had been a different spot allocated for each discount rate to count the discontinuities ... but am I right in saying that there's no real reason this would differ between discount rates?

Looking at the code for MimiIWG and PAGE2009, it cannot see how they could differ, given that the Discontinuity component does not pull from the Equity Weighting component ... which is I think the only way it could be drawing from discounted values. In general I'm moving away from the Equity Weighting component anyways to do my own discounting here, but that's besides the point

I'm not an expert on PAGE, and could be wrong, so don't waste your time digging too deep I can do that if I seem off! Just wondering if in your work you tend to expect the results to ever differ between discount rates or if those columns are always the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant