Better meminfo.c IO error handling #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`perror()` itself is not guaranteed to not modify `errno`.
The message says "fscanf() failed: %s" but then went on to print the `errno` of `fclose()`, not `fscanf()`.
Note this changes the behaviour of the function:
Before, it returned `-1` when `sysconf()` returned that
`_SC_PAGESIZE` was indeterminated, now it `fatal()`s.
This is because the function contract is
// Returns the value (>= 0) or -errno on error.
and returning `-1` is not according to that contract, because
that would mean `-EPERM`.
This was referenced Apr 25, 2020
|
I have merged everything except the fread retries, 50081ce slightly edited, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189 and also a couple other things that I found, especially in relation to
errnohandling.I recommend to review them per-commit.
Please review/test them well as I haven't managed to run the test suite yet.