Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autounmount? #128

Closed
pepa65 opened this issue Jul 18, 2017 · 8 comments
Closed

autounmount? #128

pepa65 opened this issue Jul 18, 2017 · 8 comments

Comments

@pepa65
Copy link

pepa65 commented Jul 18, 2017

Thank you for persisting with this excellent project! I should have switched way earlier. One last feature that I always use on encfs is -i <minutes> (autounmount after minutes).

Do you think this is an undesirable feature? Of course it's a bit of extra code, and it might fail as well, but I think it does increase security when it does work as intended, not having to remember to unmount manually.

@duncanka
Copy link
Contributor

Just dropped in to request this feature and found it was already requested, so adding my +1 in the hopes of raising its priority.

Adding an auto-unmount flag would also allow SiriKali to easily add support for that flag; currently, you can specify a timeout for a gocryptfs stash in SiriKali, but it doesn't actually do anything. (Of course, SiriKali could just disable that option for gocryptfs, but I'd rather see gocryptfs just support it. 😃)

@duncanka
Copy link
Contributor

Also, I might conceivably be wiling to help implement this if someone could point me to the relevant portions of the code.

@mhogomchungu
Copy link

An additional ability to specify if the mount point should be deleted or not when the volume is auto unmounted will be appreciated.

@ghost
Copy link

ghost commented Jan 8, 2018

Try this shell script?usage: ./script cipher plain sleep_time
#!/bin/sh
gocryptfs $1 $2
sleep ${3}m
fusermount -u -z $2

@pepa65
Copy link
Author

pepa65 commented Jan 8, 2018

Since I already deploy gocryptfs through a wrapper script, I'll just add it this way.

@mhogomchungu
Copy link

Auto unmount feature does not work the way that script does it.

It auto unmount a volume after a specified period if inactivity is reached. That script unconditionally try to unmount a volume after a specified time has passed since the volume was mounted. The two are completely different.

rfjakob pushed a commit that referenced this issue Oct 11, 2018
Even though filesystem notifications aren't implemented for FUSE, I decided to
try my hand at implementing the autounmount feature (#128). I based it on the
EncFS autounmount code, which records filesystem accesses and checks every X
seconds whether it's idled long enough to unmount.

I've tested the feature locally, but I haven't added any tests for this flag.
I also haven't worked with Go before. So please let me know if there's
anything that should be done differently.

One particular concern: I worked from the assumption that the open files table
is unique per-filesystem. If that's not true, I'll need to add an open file
count and associated lock to the Filesystem type instead.

#265
@mhogomchungu
Copy link

Just dropped in to request this feature and found it was already requested, so adding my +1 in the hopes of raising its priority.

Adding an auto-unmount flag would also allow SiriKali to easily add support for that flag; currently, you can specify a timeout for a gocryptfs stash in SiriKali, but it doesn't actually do anything. (Of course, SiriKali could just disable that option for gocryptfs, but I'd rather see gocryptfs just support it. smiley)

Git version of SiriKali now supports the "idle" option of gocryptfs. Latest released version of SiriKali(1.3.6) supports creating and unlocking of gocryptfs volumes in reverse mode.

@rfjakob
Copy link
Owner

rfjakob commented Nov 17, 2018

Autoumount support has been merged to master ( 87d3ed9 ) and will be in gocryptfs v1.7!

@rfjakob rfjakob closed this as completed Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants