Clarify extension creation instructions in README #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abase" The two sections shared most of their steps so keeping them separate just made duplication.
BuonOmo
approved these changes
Feb 9, 2024
keithdoggett
approved these changes
Feb 22, 2024
|
Thanks @frehoy LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Creating a Spatial Rails App" previously said "The adapter will add the PostGIS extension to your database.", which isn't true since this commit: 418c027
I updated the readme instructions to add the migration to create the extension in the "Creating a Spatial Rails App" section. It was then almost identical to the "Upgrading an Existing Database" section, so I merged the two into a new section called "Setup".
I also went for the newer style
default: &defaultstyle for theconfig/database.ymlpart.Fixes issue #389
Thanks @BuonOmo for the pointers