Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.2 #396

Closed
wants to merge 2 commits into from
Closed

Rails 7.2 #396

wants to merge 2 commits into from

Conversation

ugisozols
Copy link

No description provided.

@ugisozols ugisozols marked this pull request as draft June 4, 2024 09:46
@keithdoggett
Copy link
Member

keithdoggett commented Jun 5, 2024

Looks like we'll have to bump the minimum ruby version to >= 3.1.0. And remove 3.0 tests from the matrix in the github actions config

@seuros
Copy link
Contributor

seuros commented Jun 5, 2024

We need to use the new api in active-record so it doesn't blow up when we add other gems.

I remember i had flaky tests when i tried to do it few months ago.

@BuonOmo
Copy link
Member

BuonOmo commented Sep 4, 2024

We should close either this PR or the other ! I can champion this in a few weeks if no one has been on it by that time. @ugisozols still interested in going forward with this PR?

@ugisozols
Copy link
Author

Sorry, I got busy with other stuff so let's close this and better focus on the other one.

@ugisozols ugisozols closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants