Bump to 7.2.0 #405

BuonOmo · 2024-09-04T12:10:02Z

Closes #403
Closes #395

activerecord-postgis-adapter.gemspec

BuonOmo · 2024-09-04T12:45:55Z

lib/active_record/connection_adapters/postgis_adapter.rb

@@ -17,7 +17,6 @@
 require_relative "postgis/oid/spatial"
 require_relative "postgis/oid/date_time"
 require_relative "postgis/type" # has to be after oid/*
-require_relative "postgis/create_connection"


This is the only actual needed change according to the current test suite, but I'm trying with the whole rails test suite to be sure we do not miss anything

seuros · 2024-09-04T12:57:16Z

Rakefile

@@ -3,7 +3,7 @@ require "rake/testtask"
 require_relative "test/rake_helper"

 task default: [:test]
-task test: "test:postgis"
+task test: "test:all"


i think the whole suite is flaky.

I'll look at it. I have good experience with this suite now that I maintain the CRDB adapter. It usually is flaky due to some tests modifying the db. Which they should not do if they are correctly changed for our use case. Do you have any further information?

Just this : #378

Thx, I plan on excluding using minitest-exclude and opening an issue for excluded tests

@BuonOmo yeah I hadn't figured out how to replicate the exclusions like in the CRDB adapter, but we definitely need that here since some are failing (which is expected). But to @seuros 's point that's why I just left the postgis tests for now.

Now we only have Postgis basic tests flaky. If one of you has time to look into it it would be much appreciated. Otherwise maybe we can skip them for now and make this or top priority issue, just so we can release this ?

@BuonOmo so just to make sure I'm clear, there's a few postgis tests that were working and are now flakey? I can try to work through some of them. Is it only in the CI?

seuros · 2024-09-04T13:55:53Z

activerecord-postgis-adapter.gemspec

@@ -10,16 +10,17 @@ Gem::Specification.new do |spec|

 spec.version = ActiveRecord::ConnectionAdapters::PostGIS::VERSION
 spec.authors = ["Daniel Azuma", "Tee Parham"]


name should be updated and index matched with the emails.

these are authors, I do not consider myself as author :/

Normally, you keep the old authors and maintainers and prepend active ones.

Not according to the specification reference:

**AUTHORS=(value)

A list of authors for this gem.

[...]

EMAIL

A contact email address (or addresses) for this gem

^{https://guides.rubygems.org/specification-reference/}
I'd rather not mention myself as author unless I rewrite a significant portion of the gem alone.

seuros · 2024-09-04T13:56:29Z

test/cases/attributes_test.rb

@@ -99,20 +99,20 @@ def test_joined_spatial_attribute
 private

 def create_foo
- Foo.connection.create_table :foos, force: true do |t|
+ Foo.lease_connection.create_table :foos, force: true do |t|


these test case work in isolation

What do you mean?

I mean if you run any test that break alone, it works.

Something wrong with CI that we should fix.
Checkout https://github.com/nektos/act if you want to have your own github runner locally.

Thanks for act, I am still unsure about your first point though..

vfonic · 2024-09-10T17:28:01Z

Hey @BuonOmo! Thanks for the great work you've done so far on support for Rails 7.2!

I've tried switching to this branch and upgrading to Rails 7.2.

Here's the error I'm getting when I try to load my ActiveAdmin dashboard page, I don't know how to take it from here. I hope it's useful to you:

Thanks!

BuonOmo · 2024-09-11T14:36:37Z

@vfonic I think your issue is not related to this adapter. To make sur of this you can replace the activerecord adapter with postgresql and see if you still have the failure.

If it is related though could you open an issue with a reproducible example ? Or at least a stack trace and a gemfile.lock so I could investigate?

vfonic · 2024-09-11T18:40:30Z

Thanks @BuonOmo, I'll have a look.

What do you mean by

replace the activerecord adapter with postgresql and see if you still have the failure.

?

Thanks!

BuonOmo · 2024-09-12T04:39:55Z

@vfonic in your codebase, stop using active-record-postgis-adapter, and in your database configuration file (likely database.yml) set postgres instead of postgis. And check if this error still occurs.

feat: bump activerecord

a62542d

BuonOmo marked this pull request as ready for review September 4, 2024 12:10

BuonOmo force-pushed the bump-7-2 branch 4 times, most recently from 8d66e71 to 0ac2822 Compare September 4, 2024 12:19

feat: enable all tests

c21dbce

BuonOmo force-pushed the bump-7-2 branch from 0ac2822 to c21dbce Compare September 4, 2024 12:25

BuonOmo changed the title ~~Bump 7 2~~ Bump to 7.2.0 Sep 4, 2024

BuonOmo commented Sep 4, 2024

View reviewed changes

activerecord-postgis-adapter.gemspec Outdated Show resolved Hide resolved

BuonOmo commented Sep 4, 2024

View reviewed changes

seuros reviewed Sep 4, 2024

View reviewed changes

BuonOmo force-pushed the bump-7-2 branch from b813654 to aae145c Compare September 4, 2024 13:26

seuros reviewed Sep 4, 2024

View reviewed changes

BuonOmo force-pushed the bump-7-2 branch from aae145c to 14d81ff Compare September 4, 2024 14:32

fix: use lease_connection in tests

28cab3a

BuonOmo force-pushed the bump-7-2 branch from 14d81ff to 28cab3a Compare September 5, 2024 06:43

BuonOmo added 2 commits September 5, 2024 09:33

add tracer to figure it out

b4ed5bf

stackprof less verbose

bc31a28

BuonOmo force-pushed the bump-7-2 branch from f8b207a to afeab02 Compare September 5, 2024 09:25

enable_ext analysis

5fd9f6c

BuonOmo force-pushed the bump-7-2 branch from afeab02 to 5fd9f6c Compare September 5, 2024 09:31

enable_ext stackprof

3be96f9

BuonOmo force-pushed the bump-7-2 branch from 92e76f0 to 3be96f9 Compare September 5, 2024 09:57

BuonOmo added 2 commits September 5, 2024 12:19

show conninfo

eee50f6

debug conninfo

ec1c5ef

BuonOmo force-pushed the bump-7-2 branch from 1928703 to ec1c5ef Compare September 5, 2024 10:56

BuonOmo added 2 commits September 5, 2024 12:58

maybe reset is the culprit

342fcb2

closer

4951a6b

BuonOmo force-pushed the bump-7-2 branch from 6de26e2 to 4951a6b Compare September 5, 2024 11:10

fixed maybe

b774ae2

seuros marked this pull request as draft September 5, 2024 11:40

BuonOmo force-pushed the bump-7-2 branch from e689f06 to e033bf8 Compare September 5, 2024 11:42

cleanup

d1a4e1e

BuonOmo force-pushed the bump-7-2 branch from e033bf8 to d1a4e1e Compare September 5, 2024 11:50

BuonOmo added 3 commits September 5, 2024 15:18

add exclusions

2eef5aa

fix structure dump test

bbc38b4

add exclusions

9fb267c

BuonOmo mentioned this pull request Sep 5, 2024

Some ActiveRecord Tests Failing #378

Open

cleanup

69012e3

BuonOmo force-pushed the bump-7-2 branch from fdf5351 to 69012e3 Compare September 5, 2024 15:19

BuonOmo added 4 commits September 9, 2024 09:04

longer timeout

ada1f96

more excludes

0064eea

more excludes

9dab4f5

fix flaky tests

eea4b76

BuonOmo mentioned this pull request Sep 12, 2024

Updated versions activerecord rgeo-activerecord rubocop #406

Closed

tagliala mentioned this pull request Sep 15, 2024

Allow rgeo-activerecord 8.x #407

Closed

bump rgeo-activerecord

763cef8

This was referenced Sep 17, 2024

This needs an updated dependency to rgeo-activerecord 8.0 #409

Closed

uninitialized constant ActiveRecord::ConnectionAdapters::PostgreSQL::ColumnDefinition (NameError) #410

Open

JamesChevalier mentioned this pull request Sep 18, 2024

Error TypeError: can't cast RGeo::Geographic::SphericalPolygonImpl on Rails 7.2 and HEAD activerecord-postgis-adapter #402

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to 7.2.0 #405

Bump to 7.2.0 #405

BuonOmo commented Sep 4, 2024

BuonOmo Sep 4, 2024

seuros Sep 4, 2024

BuonOmo Sep 4, 2024

seuros Sep 4, 2024

BuonOmo Sep 4, 2024

keithdoggett Sep 9, 2024

BuonOmo Sep 9, 2024

keithdoggett Sep 11, 2024

seuros Sep 4, 2024

BuonOmo Sep 4, 2024

seuros Sep 5, 2024

BuonOmo Sep 5, 2024 •

edited

Loading

seuros Sep 4, 2024

BuonOmo Sep 4, 2024

seuros Sep 5, 2024

BuonOmo Sep 5, 2024 •

edited

Loading

vfonic commented Sep 10, 2024

BuonOmo commented Sep 11, 2024

vfonic commented Sep 11, 2024 •

edited

Loading

BuonOmo commented Sep 12, 2024

		@@ -10,16 +10,17 @@ Gem::Specification.new do \|spec\|

		spec.version = ActiveRecord::ConnectionAdapters::PostGIS::VERSION
		spec.authors = ["Daniel Azuma", "Tee Parham"]

Bump to 7.2.0 #405

Are you sure you want to change the base?

Bump to 7.2.0 #405

Conversation

BuonOmo commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BuonOmo Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BuonOmo Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

vfonic commented Sep 10, 2024

BuonOmo commented Sep 11, 2024

vfonic commented Sep 11, 2024 • edited Loading

BuonOmo commented Sep 12, 2024

BuonOmo Sep 5, 2024 •

edited

Loading

BuonOmo Sep 5, 2024 •

edited

Loading

vfonic commented Sep 11, 2024 •

edited

Loading