Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 8 support #421

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add Rails 8 support #421

wants to merge 5 commits into from

Conversation

teeparham
Copy link
Member

This PR is #419, plus two small commits:

  • Remove ruby 3.1 from the test matrix, since rails 8 requires ruby 3.2
  • Update the .gitignore file.

@teeparham teeparham marked this pull request as draft December 13, 2024 17:47
@teeparham
Copy link
Member Author

Failures seem to be related to rails/rails#53904

@januszm
Copy link

januszm commented Dec 20, 2024

I was about to suggest this test matri change to the previous PR

Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    activerecord-postgis-adapter was resolved to 10.0.0, which depends on
      Ruby (>= 3.2.0)

I think there's absolutely nothing wrong in requiring Ruby 3.2+ for this release. Applications, projecs, people who need to stick to older Ruby versions will most likely also need to stick to older Rails/ActiveRecord releases and can use older versions of this gem activerecord-postgis-adapter. Here, we can simply drop support for Ruby 3.1 with the next release. I've tested that PR in production for weeks and it works without issues.

Copy link
Member

@keithdoggett keithdoggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teeparham. This looks good! The issue you linked seems to be for rails 7.2. Do you know if it's going to be merged into the next release of 8.0 too? I tried looking around release notes and commit history but didn't see anything.

@keithdoggett
Copy link
Member

@januszm agree. Rails 8 requires 3.2+ so we should match that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants