forked from spdx/spdx-examples
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the JSON valid #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the software profile example drawio file and screenshot of the drawio diagram. The hope is that other profiles will build on top of this core example and we can generate SPDX docs for these examples to make adopting 3.0 easier. Signed-off-by: Rose Judge <rose.judge@broadcom.com>
Fix these JSON errors: - Unexpected end of string. json(258) - Invalid characters in string. Control characters must be escaped. json(262) Changes: - Remove one Start of Heading (SOH) control character inside a string value - Inside string values, replace tab with space - Make all strings a one-liner (escaped new-line character inside a string value to `\n`) - JSON cannot have a multi-line value - Replace "hrt"/"simpleHRT" with "htr"/"simpleHTR" - Keep spelling the same as https://github.com/githubharald/SimpleHTR/ - Format document - Make it easier to review on GitHub - Rename "AI" directory to "ai", to keep it consistent with the value of profileConformance ("core", "software", "ai", "dataset")
Add general software profile example
- Fix typos in class/property/type names - Convert dictionary ("key": "value") entries to SPDX 3.0 "DictionaryEntry" objects - Now validated with spdx3ToGraph Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
The JSON is now pass the validation by spdx3ToGraph. |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Fixes the github actions workflow to correctly validates SPDX 2 and SPDX 3 documents, and fixes example-13 to conform to the validation Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
":_creationinfo" -> "_:creationinfo"
Passed both ajv and check-jsonschema
Update:
|
Now pass the SHACL in PR #2. Close this PR as it has commits from other non-related stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is closed. Please use #2 instead.
The example is now structurally valid.
Passed the validation by ajv and check-jsonschema.
Changes: