Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add points issue #4

Open
nikolajevs86 opened this issue Aug 15, 2020 · 10 comments
Open

Add points issue #4

nikolajevs86 opened this issue Aug 15, 2020 · 10 comments

Comments

@nikolajevs86
Copy link

In example shows error while adding new points:
ERROR:SCRIPT: /main/editor/editor.script:228: The receiver shouldn't be nil stack traceback: [C]: in function 'post' /main/editor/editor.script:228: in function </main/editor/editor.script:207>

@rduke1982
Copy link

Seeing this as well. Looks like this is no longer working.

@rgrams
Copy link
Owner

rgrams commented Apr 12, 2021

Alright, thanks for the report! I'll take a look at it.

@rgrams
Copy link
Owner

rgrams commented Apr 13, 2021

Alright, it was a one-liner fix. Honestly I don't know how this worked ever before.

Sorry for leaving this for so long. I must have completely missed the original issue post. :S

@rgrams rgrams closed this as completed Apr 13, 2021
@rduke1982
Copy link

It's okay. I still however can't get it working. The first several clicks don't register and when the clicks start to work, they're in the wrong locations. I made a video that shows the problem.

https://monosnap.com/file/pSwGYrEyMaulXOSjYwk3OATYuwXgWL

@rgrams
Copy link
Owner

rgrams commented Apr 15, 2021

Hmm, well that's pretty messed up! No errors in the console? What happens if you resize the window? Can you try enabling the "High DPI" setting in the game.project file?

@rgrams rgrams reopened this Apr 15, 2021
@rduke1982
Copy link

No errors in the console. I used print to test input and input is being recognized.

Resizing the window almost fixes the issue. After resizing, the points appear correctly after clicking. Prior to resizing the window, the points are offset to the positive x,y positions.

I enabled High DPI and still had this issue.

Technically, it works after resizing the window, clearing the previous points, and starting a new shape.

@rgrams
Copy link
Owner

rgrams commented Apr 15, 2021

OK, thanks, that helps. Yeah, so it has something to do with the screen-to-world transformation. It's annoying that it works fine on my machine but breaks on yours. You're running it on Mac? I'll see if I can find anything. Thanks for testing.

@rduke1982
Copy link

rduke1982 commented Apr 15, 2021 via email

@rgrams
Copy link
Owner

rgrams commented Apr 23, 2021

@RaymondDuke Would you mind trying it again now to see if it's fixed?

To be honest I didn't actually diagnose that specific problem, but there was some very questionable bits in the camera/rendering code, which I replaced. The web version is working properly now, so hopefully it works on mac as well.

@rduke1982
Copy link

@rgrams I haven't had a chance to check this out yet on my mac, but I can confirm the web version works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants