Add the ability to customize the progress bars #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
issues/5/bar-opt
branch
9 times, most recently
from
71cda9a to
d312bbf
Compare
rgreinho
force-pushed
the
issues/5/bar-opt
branch
from
d312bbf to
8f5b398
Compare
mkatychev
reviewed
Apr 15, 2022
Comment on lines
+334
to
+346
| "{bar:40.green/black} {bytes:>11.green}/{total_bytes:<11.green} {bytes_per_sec:>13.red} eta {eta:.blue}"; | ||
| /// Use increasing quarter blocks as progress characters: `"█▛▌▖ "`. | ||
| pub const CHARS_BLOCKY: &'static str = "█▛▌▖ "; | ||
| /// Use fade-in blocks as progress characters: `"█▓▒░ "`. | ||
| pub const CHARS_FADE_IN: &'static str = "█▓▒░ "; | ||
| /// Use fine blocks as progress characters: `"█▉▊▋▌▍▎▏ "`. | ||
| pub const CHARS_FINE: &'static str = "█▉▊▋▌▍▎▏ "; | ||
| /// Use a line as progress characters: `"━╾─"`. | ||
| pub const CHARS_LINE: &'static str = "━╾╴─"; | ||
| /// Use rough blocks as progress characters: `"█ "`. | ||
| pub const CHARS_ROUGH: &'static str = "█ "; | ||
| /// Use increasing height blocks as progress characters: `"█▇▆▅▄▃▂▁ "`. | ||
| pub const CHARS_VERTICAL: &'static str = "█▇▆▅▄▃▂▁ "; |
mkatychev
reviewed
Apr 15, 2022
| } | ||
|
|
||
| /// Create a [`ProgressStyle`] based on the provided options. | ||
| pub fn to_progress_style(self) -> ProgressStyle { |
There was a problem hiding this comment.
You could probably do this as impl From<ProgressBarOpts> for ProgressStyle
There was a problem hiding this comment.
- let style = self.to_progress_style();
+ let style = self.into(); Line 383 in 8f5b398
There was a problem hiding this comment.
I thought of it, but then, I thought that impl From<T> implies a conversion. However here we are using some values from the options to build a ProgressStyle. Therefore It did not seem very idiomatic to me.
But maybe I was thinking about it too much. If you still don't see any problem after reading this, I'll implement the From trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the user the ability to customize the visual aspects of the main
and/or the child progress bars. The bars can now also be disabled if
needed.
Fixes #5
Fixes #6