Fix ocaml#1912

Error code of dune format should be non zero when it fails Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg · Mar 7, 2019 · 9ab7660 · aalekseyev · Mar 7, 2019 · rgrinberg
1 parent 5fc11f0
commit 9ab7660
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -27,6 +27,8 @@ unreleased
 - Fix generation of `.merlin` files on Windows. `\` characters needed
   to be escaped (#1869, @mlasson)
 
+- Fix 0 error code when `$ dune format` fails. (#1915, fix #1912, @rgrinberg)
+
 1.7.3 (unreleased)
 ------------------
 

diff --git a/src/format_dune_lang.ml b/src/format_dune_lang.ml
@@ -122,9 +122,10 @@ let pp_top_sexps =
 let format_file ~input =
   match parse_file input with
   | exception Dune_lang.Parse_error e ->
-    Printf.printf
+    Printf.eprintf
       "Parse error: %s\n"
-      (Dune_lang.Parse_error.message e)
+      (Dune_lang.Parse_error.message e);
+    exit 1
   | OCaml_syntax loc ->
     Errors.warn loc "OCaml syntax is not supported, skipping."
   | Sexps sexps ->