Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak context and fixes #37 #41

Closed
wants to merge 1 commit into from
Closed

Conversation

tsileo
Copy link

@tsileo tsileo commented May 8, 2019

Hey, here is the fix as discussed.

Thanks.

@rgrinberg
Copy link
Owner

CI needs to be fixed:

[ERROR] The compilation of mustache failed at "/home/opam/.opam/4.07/bin/dune runtest -p mustache -j 71".
- spec_mustache alias lib_test/runtest (exit 2)
- (cd _build/default/lib_test && ./spec_mustache.exe)
- Rendering of test Implicit Iterator - String from sections.json failed.
- Fatal error: exception Mustache_types.Invalid_param("Lookup.scalar: not a scalar")
- test_mustache alias lib_test/runtest (exit 2)
- (cd _build/default/lib_test && ./test_mustache.exe)
- Fatal error: exception Failure("Rendering 0 of test 2 failed: Mustache_types.Invalid_param(\"Lookup.scalar: not a scalar\")")

@tsileo
Copy link
Author

tsileo commented May 9, 2019

I missed the failing CI. I tried to take a look, looks like this "fix" add some regressions.
I don't have enough knowledge/cannot figure out why :(

@gasche
Copy link
Collaborator

gasche commented Dec 28, 2020

This tricky issue was fixed by #49, so closing this one. Thanks!

@gasche gasche closed this Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants