Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test files from bundled gem #8

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Remove test files from bundled gem #8

merged 1 commit into from
Oct 16, 2019

Conversation

t-richards
Copy link
Contributor

@t-richards t-richards commented Oct 16, 2019

Summary

This PR slims down the bundled gem by 80%.

Gem Size (bytes)
Before 92,160
After 18,432
Difference (absolute) 73,728
Difference (relative) -80.00%

I believe these savings are worth having because this gem is downloaded millions of times.

Changes

Before (details)
## Gem size
-rw-r--r-- 1 tom users 92160 Oct 15 22:57 pkg/crass-1.0.4.gem

## Gem contents
.gitignore
.travis.yml
.yardopts
Gemfile
HISTORY.md
LICENSE
README.md
Rakefile
crass.gemspec
lib/crass.rb
lib/crass/parser.rb
lib/crass/scanner.rb
lib/crass/token-scanner.rb
lib/crass/tokenizer.rb
lib/crass/version.rb
test/css-parsing-tests/An+B.json
test/css-parsing-tests/LICENSE
test/css-parsing-tests/README.rst
test/css-parsing-tests/color3.json
test/css-parsing-tests/color3_hsl.json
test/css-parsing-tests/color3_keywords.json
test/css-parsing-tests/component_value_list.json
test/css-parsing-tests/declaration_list.json
test/css-parsing-tests/make_color3_hsl.py
test/css-parsing-tests/make_color3_keywords.py
test/css-parsing-tests/one_component_value.json
test/css-parsing-tests/one_declaration.json
test/css-parsing-tests/one_rule.json
test/css-parsing-tests/rule_list.json
test/css-parsing-tests/stylesheet.json
test/css-parsing-tests/stylesheet_bytes.json
test/shared/parse_rules.rb
test/support/common.rb
test/support/serialization/animate.css
test/support/serialization/bootstrap-theme.css
test/support/serialization/bootstrap.css
test/support/serialization/html5-boilerplate.css
test/support/serialization/misc.css
test/support/serialization/pure.css
test/test_crass.rb
test/test_css_parsing_tests.rb
test/test_parse_properties.rb
test/test_parse_rules.rb
test/test_parse_stylesheet.rb
test/test_serialization.rb
After (details)
## Gem size
-rw-r--r-- 1 tom users 18432 Oct 15 22:57 pkg/crass-1.0.4.gem

## Gem contents
.gitignore
.travis.yml
.yardopts
Gemfile
HISTORY.md
LICENSE
README.md
Rakefile
crass.gemspec
lib/crass.rb
lib/crass/parser.rb
lib/crass/scanner.rb
lib/crass/token-scanner.rb
lib/crass/tokenizer.rb
lib/crass/version.rb

@rgrove rgrove merged commit 1608f38 into rgrove:master Oct 16, 2019
@rgrove
Copy link
Owner

rgrove commented Oct 16, 2019

Thanks!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 17, 2020
Update ruby-crass to 1.0.6.


1.0.6 (2020-01-12)
------------------

* Number values are now limited to a maximum of `Float::MAX` and a minimum of
  negative `Float::MAX`. (#11)

* Added project metadata to the gemspec. (#9 - @orien)


1.0.5 (2019-10-15)
------------------

* Removed test files from the gem. [@t-richards - #8][8]

[8]:rgrove/crass#8


1.0.4 (2018-04-08)
------------------

* Fixed whitespace warnings. (#7 - @yahonda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants