Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity Æ is converted to Æ;, is this a little bug? #119

Closed
syjstc opened this issue Oct 28, 2014 · 5 comments
Closed

Entity Æ is converted to Æ;, is this a little bug? #119

syjstc opened this issue Oct 28, 2014 · 5 comments
Labels
bug gumbo / nokogumbo
Milestone
3.1.0

Comments

@syjstc
Copy link

syjstc commented Oct 28, 2014

val = "Æ"
=> "Æ"
r = Sanitize.fragment(val, Sanitize::Config.merge(Sanitize::Config::BASIC))
=> "Æ;"

can you fix it, thanks
@rgrove
Copy link
Owner

rgrove commented Oct 28, 2014

This was a bug in the Gumbo parser (see issue #114) that was fixed in Sanitize 3.0.2. If you upgrade, it should no longer be a problem.

@rgrove rgrove closed this as completed Oct 28, 2014
@rgrove rgrove reopened this Oct 28, 2014
@rgrove
Copy link
Owner

rgrove commented Oct 28, 2014

I take that back; looks like this particular entity still has a problem. I'll look into getting it fixed.

@rgrove rgrove added bug and removed question labels Oct 28, 2014
@syjstc
Copy link
Author

syjstc commented Oct 28, 2014

Alright, thanks. Waiting for your good news.

@rgrove rgrove mentioned this issue Oct 28, 2014
Merged
@rgrove rgrove modified the milestones: 3.0.3, 3.1.0 Oct 28, 2014
@rgrove
Copy link
Owner

rgrove commented Dec 18, 2014

Just need to get the updated gumbo code into nokogumbo, then I can release Sanitize 3.1.0 with the fix.

rubys/nokogumbo#16

@rgrove rgrove closed this as completed in 4db352f Dec 23, 2014
@rgrove
Copy link
Owner

rgrove commented Dec 23, 2014

I've released Sanitize 3.1.0 with this fix. Sorry for the long wait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug gumbo / nokogumbo
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@rgrove @syjstc