Skip to content
This repository has been archived by the owner on Aug 26, 2023. It is now read-only.

Update gumbo to d6b952b4 to pick up another entity parsing fix #16

Closed
rgrove opened this issue Dec 18, 2014 · 2 comments
Closed

Update gumbo to d6b952b4 to pick up another entity parsing fix #16

rgrove opened this issue Dec 18, 2014 · 2 comments

Comments

@rgrove
Copy link
Contributor

rgrove commented Dec 18, 2014

Would you mind updating gumbo to commit d6b952b4bcfa15c8f9bc28f56457b969e7f96ffe to pick up another entity parsing fix?

I'd submit a PR, but I've gotten the impression that PRs containing subproject commit bumps cause you more work than they save you. Happy to submit one if you'd prefer.

@rubys
Copy link
Owner

rubys commented Dec 22, 2014

Thanks!

Background on the problem I've had: GitHub provides a button I can use to merge a pull request. Unfortunately, when I then pull the updated master down to my machine, it doesn't update the gumbo submodule version. What's worse is that if I later push, that causes the submodule version to be updated. Not sure why it happens.

@rgrove
Copy link
Contributor Author

rgrove commented Dec 22, 2014

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants