Optimized memory usage #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks for digging into this. 👍 I'd like to merge the memory usage improvements, but I'm not interested in the style changes right now. Would you mind reverting those changes and leaving only the memory optimizations? |
janklimo
force-pushed
the
optimize-memory-usage
branch
from
ac980e4
to
caa558a
Compare
|
You got it @rgrove 👍 |
|
Merged and released as 4.6.2. 🍻 |
This was referenced Mar 20, 2018
stanhu
added a commit
to stanhu/sanitize
that referenced
this pull request
Jul 24, 2018
In 4.6.2, rgrove#175 significantly cut down on memory usage by caching the lowercase version of the node name. However, as reported in rgrove#177, this broke certain transformers that modified the node name since the name was cached. We can bring back this optimization by updating the node name only if it has been changed. Closes rgrove#184
stanhu
added a commit
to stanhu/sanitize
that referenced
this pull request
Jul 24, 2018
In 4.6.2, rgrove#175 significantly cut down on memory usage by caching the lowercase version of the node name. However, as reported in rgrove#177, this broke certain transformers that modified the node name since the name was cached. We can bring back this optimization by updating the node name only if it has been changed. Closes rgrove#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #173 I found some ways to make
sanitizeallocate less objects/memory (and added some basic Rubocop-driven cleanup).The most effective change is that
node_nameis created only once intransform_node!(while previously it was allocated once per each transformer). In my quick test, this leads to significant savings.Before
After
That amounts to 5.3MB less memory allocated, i.e. saving of ~16%.