Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure protocol processing happens on data attributes #207

Merged
merged 1 commit into from
Jan 11, 2021
Merged

ensure protocol processing happens on data attributes #207

merged 1 commit into from
Jan 11, 2021

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jan 11, 2021

this was broken in 4.6.3 by 01629a1

rgrove
rgrove approved these changes Jan 11, 2021
View reviewed changes
Copy link
Owner

@rgrove rgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think it may have been an accident that protocols were being sanitized in data attributes (at least, I don't remember ever intending that to happen), but we should definitely maintain backcompat here in any case.

@rgrove rgrove merged commit fac1a2e into rgrove:master Jan 11, 2021
This was referenced Mar 17, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrove rgrove rgrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccutrer @rgrove