feat(create-module): use stencil-golang to create modules #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for generating modules with a `manifest.yaml` as well as populating `service.yaml` using `rgst-io/stencil-golang` in library mode, unless specified to create a native extension. stencil-golang in library mode has full CI, and is used mainly only for releasing. Eventually, the release logic will be moved out and turned into some framework (or use some other one) since it is a bit awkward to depend on that for non-Go repositories.
Deploying stencil with
|
| Latest commit: |
4e0d2ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bbee0be0.stencil-1wj.pages.dev |
| Branch Preview URL: | https://jaredallard-feat-stencil-cre.stencil-1wj.pages.dev |
jaredallard
commented
Aug 31, 2024
cmd/stencil/create_module.go
Outdated
|
|
||
| // ensure we have a name | ||
| if c.NArg() != 1 { | ||
| return errors.New("must provide a name for the module") | ||
| } | ||
|
|
||
| moduleName := c.Args().Get(0) | ||
| hasPlugin := false |
There was a problem hiding this comment.
NTS: Hook this up to the type flag.
jaredallard
commented
Aug 31, 2024
pkg/configuration/type.go
Outdated
There was a problem hiding this comment.
Changed type from cvs to a string slice since cvs never really made much sense and screws with the JSON schema
jaredallard
commented
Aug 31, 2024
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Not used any more since we got rid of gobox awhile back.
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
|
PR is in draft state because I'm on a plane with a pretty bad headache and this is the most I could manage before landing 🚀 |
jaredallard
deleted the
jaredallard/feat/stencil-create-module-framework
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for generating modules with a
manifest.yamlas well aspopulating
service.yamlusingrgst-io/stencil-golangin librarymode, unless specified to create a native extension.
stencil-golang in library mode has full CI, and is used mainly only for
releasing. Eventually, the release logic will be moved out and turned
into some framework (or use some other one) since it is a bit awkward to
depend on that for non-Go repositories.