fix: Cross-module calls should execute in the context of the callee #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying stencil with
|
| Latest commit: |
495be80
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14ca8f12.stencil-1wj.pages.dev |
| Branch Preview URL: | https://ddr-crossmodule.stencil-1wj.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Mind filling out the desc for why on this change for the future? I'll need to look at this one more in-depth, we pass around template in various places to make it easier to know what's going on. The downside there is that I'm very sure that there's something missed in this. |
|
Ok, I checked it out. I forgot that I made sure this would be safe by having the |
|
|
jaredallard
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original design was to use the context of the caller in the functions being called, but after we tried to implement a function call this way realized that it was inverting ownership from usual function ownership. The idea was to be able to use helper functions in the context of the caller, but the reality is that you want to pass in any needed context to the exported function, just like in standard programming. This way the function owner can have "private" state/context inside the module that the function exposes a part of, per standard modules in general software engineering.