Fast forward to main #141
Merged
Fast forward to main #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Background / Context recert recently added a `--proxy` feature that replaces the proxy configuration in the cluster # Issue / Requirement / Reason for change The `--proxy` feature is not working as expected, some rollouts happen due to the order of the proxy env vars in the kube-apiserver's and kube-controller-manager's container's env. Seems to happen a few times before the cluster stabilizes This is simply because of a typo in the code, the `HTTP_PROXY` and `HTTPS_PROXY` env vars are being swapped in the `generic_proxy_fix` function # Solution / Feature Overview Fix the typo in the `generic_proxy_fix` function # Other Information The back-and-forth rollouts in e.g. kube-apiserver are due to the `KubeAPIServer` CR being at first in correct, which causes the deployment of the `kube-apiserver` to change, then another controller reads the fixes the `KubeAPIServer` CR itself, which then causes yet another revision Also made some changes to the tests, even though those changes would not have caught this bug.
OCPBUGS-33471: Fix proxy ordering
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.