Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also allow comma separation for CnSanReplace to support IPv6 #40

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

omertuc
Copy link
Member

@omertuc omertuc commented Oct 26, 2023

Also remove old space separation as it's not used anywhere

Also remove old space separation as it's not used anywhere
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omertuc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsorya
Copy link
Member

tsorya commented Oct 27, 2023

/lgtm

@omertuc
Copy link
Member Author

omertuc commented Oct 27, 2023

/test e2e-aws-ovn-single-node-recert-serial

@omertuc
Copy link
Member Author

omertuc commented Oct 27, 2023

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@omertuc: The following commands are available to trigger required jobs:

  • /test cargo-check
  • /test cargo-clippy
  • /test e2e-aws-ovn-single-node-recert-parallel
  • /test e2e-aws-ovn-single-node-recert-serial
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-rh-ecosystem-edge-recert-main-cargo-check
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial
  • pull-ci-rh-ecosystem-edge-recert-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omertuc
Copy link
Member Author

omertuc commented Oct 27, 2023

/test e2e-aws-ovn-single-node-recert-parallel

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@omertuc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-recert-serial fae556a link true /test e2e-aws-ovn-single-node-recert-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@omertuc omertuc merged commit b9570bd into rh-ecosystem-edge:main Oct 27, 2023
1 check passed
@omertuc omertuc deleted the space branch October 27, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants