Flip bit to make not shiny instead of rerolling #3640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some context for whoever reviews this: because #3438 is able to cheat it also avoids looping. I don't think there's anything wrong with this approach though. "So many times" is probably an overstatement in a lot of cases, naively we'd think it's 1/4096 to roll the RNG twice, 1/(4096*4096) to roll the RNG thrice, etc. |
AsparagusEduardo
requested changes
Dec 7, 2023
Okay, I edited the PR description and everything. |
This is better than advancing the RNG because it avoids looping and it makes more IVs accessible.
|
Irrelevant now that #3438 is a thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't have anything for the inverse yet. I just think this is better than a while loop.
Better than advancing the RNG when it has a shiny and allows for more IVs to be possible or accessible.
Discord contact info
roseareazero