Skip to content

Commit

Permalink
Align default login attribute across services
Browse files Browse the repository at this point in the history
Up to now the builtin lico was using the "username" as the login
attribute, while the proxy (and to some extend the auth-basic) service
tried to uniquely identify users by mail address. This aligns the
default configuration of the services to use the username everywhere.

Fixes: owncloud#4039
  • Loading branch information
rhafer committed Jul 14, 2022
1 parent ab556b0 commit 8069f24
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-align-login-attr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Logging in on the wrong account when an email address is not unique

The default configuration to use the same logon attribute for all services. Also,
if the configured logon attribute is not unique access to ocis is denied.

https://github.com/owncloud/ocis/issues/4039
2 changes: 1 addition & 1 deletion services/auth-basic/pkg/config/defaults/defaultconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func DefaultConfig() *config.Config {
GroupBaseDN: "ou=groups,o=libregraph-idm",
UserScope: "sub",
GroupScope: "sub",
LoginAttributes: []string{"uid", "mail"},
LoginAttributes: []string{"uid"},
UserFilter: "",
GroupFilter: "",
UserObjectClass: "inetOrgPerson",
Expand Down
4 changes: 2 additions & 2 deletions services/proxy/pkg/config/defaults/defaultconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ func DefaultConfig() *config.Config {
Enabled: true,
},
AccountBackend: "cs3",
UserOIDCClaim: "email",
UserCS3Claim: "mail",
UserOIDCClaim: "preferred_username",
UserCS3Claim: "username",
AutoprovisionAccounts: false,
EnableBasicAuth: false,
InsecureBackends: false,
Expand Down

0 comments on commit 8069f24

Please sign in to comment.