Silence some compiler warnings about unused imports #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
|
Well, currently the coding style is that unused imports are OK in tests and other non-lib places. You'll need to test most feature combinations to check if they're safe to remove... Although the tests show that it is safe... Rhai has a large number of features and silencing all warnings will need to explicitly qualify a lot of things in lots of places. We try to silence warnings for lib code so projects using Rhai won't get unnecessary compile warnings |
|
I do find the warnings very distracting as I was looking into improving the #899 situation and I'm also not attempting to fix the remaining 2 or 3 gnarlier ones. But I'm fine closing this PR if you don't want to address this cosmetic issue. |
|
Let's run the CI and see... |
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying something with the tests I noticed that there're some unused import warnings which can easily be silenced.