Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence some compiler warnings about unused imports #900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

therealprof
Copy link

While trying something with the tests I noticed that there're some unused import warnings which can easily be silenced.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@schungx
Copy link
Collaborator

schungx commented Jul 17, 2024

Well, currently the coding style is that unused imports are OK in tests and other non-lib places.

You'll need to test most feature combinations to check if they're safe to remove... Although the tests show that it is safe...

Rhai has a large number of features and silencing all warnings will need to explicitly qualify a lot of things in lots of places.

We try to silence warnings for lib code so projects using Rhai won't get unnecessary compile warnings

@therealprof
Copy link
Author

I do find the warnings very distracting as I was looking into improving the #899 situation and I'm also not attempting to fix the remaining 2 or 3 gnarlier ones. But I'm fine closing this PR if you don't want to address this cosmetic issue.

@schungx
Copy link
Collaborator

schungx commented Jul 17, 2024

Let's run the CI and see...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants