transpile bundles for ie support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add polyfills git ignore parcel's .cache directory
jpray
commented
Jul 29, 2019
| // setTimeout is to avoid browserSync throwing an error | ||
| // after the IE11 transpile is done | ||
| setTimeout(function() { | ||
| transpileForIE("dist"); |
There was a problem hiding this comment.
If you comment out this "transpileForIE" call in the dev task, you'll at least have accurate source maps while developing. Just won't be able to develop using IE.
rhali786
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on my VM and this seems to work ok. A couple notes:
Currently this ES5 bundle is being served to all browsers. I usually create 2 separate bundles, one for modern browsers and one for IE11 and conditionally serve one or the other using something like https://github.com/muicss/loadjs . Let me know if you want me to setup an example of that too.
The reason we are having to build the code with parcel and then run it through babel separately is that the Polymer team (Lit-Element) is only distributing their code as ES6 modules (no commonJS or AMD options). In addition, Parcel (and maybe webpack too) don't want to transpile anything within the node_modules directory as that would slow down the build quite a bit if they transpiled everything. Maybe webpack has already addressed this, note sure, but it should be available in Parcel in the future: babel transpile node_module dependencies parcel-bundler/parcel#1655
Because we are transpiling the JS AFTER source maps were created, the source maps are almost certainly wrong, so you should disable JS source maps in the browser when debugging. : (