Use https for github sources (github deprecated insecure git) #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github have recently dropped support for fetching sources using the
git
protocol (port 9418) in a bid to prevent MITM issues.Subsequently trying to fetch a source defined with the
github
option will result in:This change swaps out the insecure
git
protocol forhttps
in the DSL parsing.Note of course that this would still allow someone to specify the
git
protocol using thegit
option, however given this issue is only specific to Github, that would seem perfectly reasonable.This could do with some sort of explanation in the README, however it very much comes down to how the git content is hosted so very likely outside the scope of this project