Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build issues on MacOS caused by unset rpath #412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheLouisHong
Copy link

Similar to Linux, the rpath is now set to @loader_path, the mac version of $ORIGIN on Linux.

Now also moves *.dylibs (macs' version of dll) from lib to install.

Similar to Linux, the rpath is now set to @loader_path, the mac version of $ORIGIN on Linux.

Now also moves *.dylibs (macs' version of dll) from lib to install.
@jmtatsch
Copy link

worked well for me, thank you!

@damageboy
Copy link

Worked for me as well!

@cryptomilk
Copy link

cryptomilk commented Mar 12, 2024

From a cmake point of view this is wrong. You should not manipulate the CFLAGS. On Linux you need to use:

set_target_properties(piper PROPERTIES BUILD_RPATH_USE_ORIGIN TRUE)

and and MacOSX:

set_target_properties(piper PROPERTIES MACOSX_RPATH TRUE)

according to: https://cmake.org/cmake/help/latest/prop_tgt/MACOSX_RPATH.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants