DO NOT MERGE: expansion of dwalsh's comparison script #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add podman-commands.sh to compare man pages to commands. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Something that compares _all_ subcommands. It's a horrible mess because some man pages display COMMANDS and some display SUBCOMMANDS; and some show the subcommand name in the first column, others show the podman-xxx man page; and there are inconsistencies galore. This is a fake PR so Dan can look at the rest of the inconsistencies that his script didn't look at Signed-off-by: Ed Santiago <santiago@redhat.com>
|
@rhatdan what a can of worms! I hope this helps you expand upon your PR |
rhatdan
force-pushed
the
man
branch
7 times, most recently
from
876505c to
b4b7b29
Compare
|
@edsantiago Nice, I moved my script to hack/ directory, Could you fix this PR to point to there. Does your script check all of the subcommands? podman |
|
@rhatdan my logic is to run I will clean up my code and resubmit it under |
rhatdan
pushed a commit
that referenced
this pull request
Jul 11, 2019
It's desirable to make archives available of builds containing actual
tested content. While not official distro-releases, these will enable
third-party testing, experimentation, and development for both branches
(e.g. "master") and pull requests (e.g. "pr3106").
* Add a Makefile targets for archiving both regular podman binaries
and the remote-client. Encode release metadata within these
archives so that their exact source can be identified.
* Fix bug with cross-compiling remote clients for the Windows and Darwin
platforms.
* Add unit-testing of cross-compiles for Windows and Darwin platforms.
* A few small CI-script typo-fixes
* Add a script which operates in two modes:
1. Call Makefile targets which produce release archives.
Upload the archive to Cirrus-CI's built-in caching system
using reproducible cache keys.
2. Utilize reproduced cache keys to attempt download of cache
from each tasks. When successful, parse the file's
release metadata, using it to name the archive file. Upload
all recovered archives to a publicly accessible storage bucket
for future reference.
* Update the main testing task to call the script in mode #1 for
all primary platforms.
* Add a new `$SPECIALMODE` task to call the script in mode #1 for
Windows and Darwin targets.
* Add a new 'release' task to the CI system, dependent upon all other
tasks. This new tasks executes the script in mode #2.
* Update CI documentation
Signed-off-by: Chris Evich <cevich@redhat.com>
rhatdan
pushed a commit
that referenced
this pull request
Jun 15, 2020
rhatdan
pushed a commit
that referenced
this pull request
Apr 28, 2021
Our current #1 flake; this is a simple one: we can't run 'logs' on a container run with '-d --rm'. Signed-off-by: Ed Santiago <santiago@redhat.com>
rhatdan
pushed a commit
that referenced
this pull request
Sep 8, 2021
go test -v -p 1 -tags apparmor,ostree,seccomp,selinux,systemd github.com/containers/podman/v2/test/testvol results in the following error: > test/testvol/main.go:227:10: Errorf format %s reads arg #1, but call has 0 args > test/testvol/main.go:233:10: Errorf format %s reads arg #1, but call has 0 args This patch passes req.Name as an argument to the Errorf() call Signed-off-by: Raoul Bhatia <raoul.bhatia@radarcs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that compares all subcommands. It's a horrible
mess because some man pages display COMMANDS and some
display SUBCOMMANDS; and some show the subcommand name
in the first column, others show the podman-xxx man page;
and there are inconsistencies galore.
This is a fake PR so Dan can look at the rest of the
inconsistencies that his script didn't look at
Signed-off-by: Ed Santiago santiago@redhat.com