Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/howtofit docs #1022

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Feature/howtofit docs #1022

merged 7 commits into from
Jul 5, 2024

Conversation

Jammy2211
Copy link
Collaborator

I am preparing a lecture course for UK PhD students.

This PR updates a few aspects of the source code to make the lectures clearer:

  1. Updates docs describing autofit.
  2. Disables and changes some logging, to make it clear what the code is doing.

One annoying thing I had to do was disable the following at the top of the Search:

        if name is None and path_prefix is None:
            self.disable_output = True
        else:
            self.disable_output = False

Whether or not output occurs is becoming more and more confusing (the logging configs changed the desired behaviour which is why I had to set this parameter).

This will be cleaned up in the future but no time to deal with whilst I write the lectures.

@Jammy2211 Jammy2211 requested a review from rhayes777 July 5, 2024 08:03
@Jammy2211 Jammy2211 merged commit c0ab8cd into main Jul 5, 2024
0 of 8 checks passed
@Jammy2211 Jammy2211 deleted the feature/howtofit_docs branch July 23, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants