-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/sub analysis aggregator #708
Conversation
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 81.78% 81.89% +0.10%
==========================================
Files 180 180
Lines 13190 13219 +29
==========================================
+ Hits 10788 10826 +38
+ Misses 2402 2393 -9 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This seems to work:
Is there any way to do the
I probably doesn't matter but would make it easier to maintain a consistent API in places. |
The reason is that generators may combine the two types of fits:
|
Done |
Resolves #705.
Values from child analyses can be obtained using the
child_values
methodFits which are not top-level are filtered out during aggregation. These fits can be included by setting a flag.